fix(jsx): correct source location when react-jsx and whitespace before jsx#61534
Merged
jakebailey merged 3 commits intomicrosoft:mainfrom Feb 5, 2026
Merged
fix(jsx): correct source location when react-jsx and whitespace before jsx#61534jakebailey merged 3 commits intomicrosoft:mainfrom
jakebailey merged 3 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
Contributor
Author
|
I've applied the same fix for fragments as well, as they seemed to use the same pattern for source location handling. |
AviVahl
force-pushed
the
fix-jsxdev-source-location
branch
from
ffaf949 to
484a445
Compare
typescript-bot
added
For Milestone Bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect source location information in JSX transformation when using react-jsx mode with whitespace before JSX elements. The issue was that the code was using node.pos (which includes leading trivia) instead of node.getStart() (which excludes leading trivia), causing column numbers in generated code to be off by the amount of leading whitespace.
Key changes:
- Updated
visitJsxElement,visitJsxSelfClosingElement, andvisitJsxFragmentfunctions to usegetTokenPosOfNode()for accurate source location - All test baselines now show corrected column numbers that match Babel's output
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/compiler/transformers/jsx.ts | Modified JSX visitor functions to use getTokenPosOfNode() for correct source locations |
| tests/baselines/reference/tsxReactEmit8(jsx=react-jsxdev).js | Updated baseline with corrected line and column numbers |
| tests/baselines/reference/reactImportUnusedInNewJSXEmit(jsx=react-jsxdev).js | Updated baseline with corrected column numbers |
| tests/baselines/reference/jsxRuntimePragma(jsx=react-jsxdev).js | Updated baseline with corrected column numbers |
| tests/baselines/reference/jsxNamespaceNoElementChildrenAttributeReactJsx(jsx=react-jsxdev).js | Updated baseline with corrected column numbers |
| tests/baselines/reference/jsxNamespaceElementChildrenAttributeIgnoredWhenReactJsx(jsx=react-jsxdev).js | Updated baseline with corrected line and column numbers |
| tests/baselines/reference/jsxJsxsCjsTransformSubstitutesNamesFragment(jsx=react-jsxdev).js | Updated baseline with corrected column numbers |
| tests/baselines/reference/jsxJsxsCjsTransformSubstitutesNames(jsx=react-jsxdev).js | Updated baseline with corrected column numbers |
| tests/baselines/reference/jsxJsxsCjsTransformNestedSelfClosingChild(jsx=react-jsxdev).js | Updated baseline with corrected line and column numbers |
| tests/baselines/reference/jsxJsxsCjsTransformKeyPropCustomImportPragma(jsx=react-jsxdev).js | Updated baseline with corrected column numbers |
| tests/baselines/reference/jsxJsxsCjsTransformKeyPropCustomImport(jsx=react-jsxdev).js | Updated baseline with corrected column numbers |
| tests/baselines/reference/jsxJsxsCjsTransformKeyProp(jsx=react-jsxdev).js | Updated baseline with corrected column numbers |
| tests/baselines/reference/jsxJsxsCjsTransformCustomImportPragma(jsx=react-jsxdev).js | Updated baseline with corrected column numbers |
| tests/baselines/reference/jsxJsxsCjsTransformCustomImport(jsx=react-jsxdev).js | Updated baseline with corrected column numbers |
| tests/baselines/reference/jsxJsxsCjsTransformChildren(jsx=react-jsxdev).js | Updated baseline with corrected column numbers |
| tests/baselines/reference/jsxEmptyExpressionNotCountedAsChild(jsx=react-jsxdev).js | Updated baseline with corrected line and column numbers |
| tests/baselines/reference/commentsOnJSXExpressionsArePreserved(jsx=react-jsxdev,module=system,moduledetection=legacy).js | Updated baseline with corrected column numbers |
| tests/baselines/reference/commentsOnJSXExpressionsArePreserved(jsx=react-jsxdev,module=system,moduledetection=force).js | Updated baseline with corrected column numbers |
| tests/baselines/reference/commentsOnJSXExpressionsArePreserved(jsx=react-jsxdev,module=system,moduledetection=auto).js | Updated baseline with corrected column numbers |
| tests/baselines/reference/commentsOnJSXExpressionsArePreserved(jsx=react-jsxdev,module=commonjs,moduledetection=legacy).js | Updated baseline with corrected column numbers |
| tests/baselines/reference/commentsOnJSXExpressionsArePreserved(jsx=react-jsxdev,module=commonjs,moduledetection=force).js | Updated baseline with corrected column numbers |
| tests/baselines/reference/commentsOnJSXExpressionsArePreserved(jsx=react-jsxdev,module=commonjs,moduledetection=auto).js | Updated baseline with corrected column numbers |
AviVahl
force-pushed
the
fix-jsxdev-source-location
branch
2 times, most recently
from
54739ab to
fe90a2f
Compare
Contributor
Author
|
rebased to latest EDIT: and again, as |
AviVahl
force-pushed
the
fix-jsxdev-source-location
branch
from
fe90a2f to
3539c8b
Compare
…e jsx fixes microsoft#61533 the code seemed to be using `node.pos` (`node.getFullStart()`) instead of `node.getStart()`, which caused the source location to be off. now baselines match babel's output (which seems correct). not sure about using `getTokenPosOfNode()` (used by `getStart()`), but didn't find any better way to do things internally.
AviVahl
force-pushed
the
fix-jsxdev-source-location
branch
from
3539c8b to
90f16db
Compare
jakebailey
reviewed
Feb 5, 2026
Member
|
LGTM but I would switch to |
per PR review
jakebailey
reviewed
Feb 5, 2026
jakebailey
approved these changes
Feb 5, 2026
Contributor
Author
|
Thank you. Been waiting for a while for this one to get in. |
Member
|
Yes, there's a board, and Copilot is good at porting these. We have yet to start targeting 6.0 in the Go code, though, but that will happen ~today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the code seemed to be using
node.pos(node.getFullStart()) instead ofnode.getStart(), which caused the source location to be off.now baselines match babel's output (which seems correct).
not sure about using
getTokenPosOfNode()(used bygetStart()), but didn't find any better way to do things internally.fixes #61533